Profile: Rich

Statistics
Avatar
  • 8

We started with a new 4.40 database.  We wrote a custom product import process to load our products, product tags, and categories.  We use the following code to create new product tags:


                var productTag = _productTagService.GetProductTagByName(tagName);
                if (productTag == null)
                {
                    //add new product tag
                    productTag = new ProductTag
                    {
                        Name = tagName,
                        Count = 0,
                    };
                    _productTagService.InsertProductTag(productTag);
                }


Looks like we have to force our tags to lowercase before inserting.  Should the lowercase constraint be enforced at the service level inside of _productTagService.InsertProductTag(productTag)?

Wednesday, March 13, 2019 5:53 PM

Deleting a product tag for a product is throwing a null reference exception if a tag contains uppercase letters.

System.NullReferenceException: Object reference not set to an instance of an object.
at Grand.Web.Areas.Admin.Services.ProductViewModelService.SaveProductTags(Product product, String[] productTags) in C:\dev\Grand.Web\Areas\Admin\Services\ProductViewModelService.cs:line 192

Also, adds lowercase tags to product record, essentially duplicating tags.

Wednesday, March 13, 2019 2:34 PM

Thanks for the quick turnaround.

Wednesday, March 13, 2019 11:52 AM

When deleting a product tag on the product edit admin page and saving changes, the tag is not getting removed from the product.  Verified on local copy and GrandNode 4.40 demo site.

Tuesday, March 12, 2019 9:02 PM

Congrats Patryk and Team!  Look forward to working with the new release.

Tuesday, March 12, 2019 12:03 PM

To sort product attributes by display order in the shopping cart, I also added an OrderBy to the following code in ShoppingCartViewModelService.cs:


public virtual string ParseProductAttributes(Product product, IFormCollection form)
        {
            string attributesXml = "";

            #region Product attributes
            var productAttributes = product.ProductAttributeMappings.OrderBy(x => x.DisplayOrder);

Tuesday, February 5, 2019 1:37 PM

Bill wrote:

Rich,

Same issue with 4.30.  However, looks like this was fixed with commit a5f0a18df7029a7f07a54541f548190fe54f0f06 so you should see it working correctly with GrandNode 4.40.



Thanks, Bill, for the link to the specific fix.

Monday, February 4, 2019 1:06 PM

In v4.20 product attributes are not sorted by display order on both the product details page and quick view.

Friday, February 1, 2019 2:45 PM